Add maplist filter window and environment filtering#310
Open
AroPix wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
I just noticed, it should also be able to handle the new custom envs, but ill add that at some point if this pr is even desired to get approved. |
wsrvn
requested changes
Feb 27, 2026
wsrvn
left a comment
wsrvn
left a comment
Collaborator
There was a problem hiding this comment.
lgtm besides a few nitpicks, maybe some more descriptive method names could be beneficial too, but since they are used only within this file it should be fine
AroPix
force-pushed
the
feature/maplist-filtering
branch
from
974bd0f to
68a4c9c
Compare
Contributor
Author
this is how it looks like with nations packmask btw (we only have Stadium maps then)
I also forgot to add the Filters to the navbar (like it is on my servers), so i added that aswell: It also supports the custom envs now, but i removed NewSnowCar, as it is not a env but just a car anyway. |
wsrvn
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a window to filter maps:
Also adds a argument to filter for Environment, if the server is not Nations packmask.
/list $e Snow as example.
I'm open to feedback. :)